[Mesa-dev] [PATCH 2/2] mesa: move _mesa_half_is_negative() to half_float.h

[Jason Ekstrand]

On Mon, Oct 9, 2017 at 7:29 PM, Brian Paul <brianp at vmware.com> wrote:

> v2: use !! in the function to be explicit about type conversion.  Though,
> gcc generates the same code with or without the logical !!.
> ---
>  src/mesa/main/imports.h | 6 ------
>  src/util/half_float.h   | 8 ++++++++
>  2 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h
> index a4964a3..51fa72c 100644
> --- a/src/mesa/main/imports.h
> +++ b/src/mesa/main/imports.h
> @@ -333,12 +333,6 @@ _mesa_bitcount_64(uint64_t n);
>  #endif
>
>
> -static inline bool
> -_mesa_half_is_negative(GLhalfARB h)
> -{
> -   return h & 0x8000;
> -}
> -
>  extern int
>  _mesa_snprintf( char *str, size_t size, const char *fmt, ... )
> PRINTFLIKE(3, 4);
>
> diff --git a/src/util/half_float.h b/src/util/half_float.h
> index 64f2042..b3bc3f6 100644
> --- a/src/util/half_float.h
> +++ b/src/util/half_float.h
> @@ -25,6 +25,7 @@
>  #ifndef _HALF_FLOAT_H_
>  #define _HALF_FLOAT_H_
>
> +#include <stdbool.h>
>  #include <stdint.h>
>
>  #ifdef __cplusplus
> @@ -34,6 +35,13 @@ extern "C" {
>  uint16_t _mesa_float_to_half(float val);
>  float _mesa_half_to_float(uint16_t val);
>
> +static inline bool
> +_mesa_half_is_negative(uint16_t h)
> +{
> +   return !!(h & 0x8000);
>

I personally find != 0 to be easier to read.  Either way,

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>


> +}
> +
> +
>  #ifdef __cplusplus
>  } /* extern C */
>  #endif
> --
> 1.9.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171009/4cb06b5d/attachment.html>