[Mesa-dev] dri3 thread safe

Thomas Hellstrom thellstrom at vmware.com
Tue Oct 10 08:39:09 UTC 2017


Hi, Gregory.

I just noticed the following text in dri3_glx.c:

63b78c93 (Gregory Hainaut   2017-05-29 13:18:26 +0200  506)    /* Unlike 
DRI2, DRI3 doesn't call GetBuffers/GetBuffersWithFormat
63b78c93 (Gregory Hainaut   2017-05-29 13:18:26 +0200  507)     * during 
draw so we're safe here.
63b78c93 (Gregory Hainaut   2017-05-29 13:18:26 +0200  508)     */

This isn't true anymore, as dri3 now invalidates drawables 
asynchronously, as the previous code generated numerous viewport
inconsistencies and rendering errors. Do we need to explicitly make dri3 
thread-safe for your glthread work?

Thanks,

Thomas





More information about the mesa-dev mailing list