[Mesa-dev] [PATCH 01/15] i965: Complete 'expose RGBA visuals only on Android'

[Tapani Pälli]

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

I think this fix can/should land separately from the set.

On 10/06/2017 07:11 PM, Mario Kleiner wrote:
> Commit 731ba6924a2ed6cdf47a78fd637a91a19ddcf9ed
> "expose RGBA visuals only on Android" replaced
> ARRAY_SIZE(formats) by num_formats, but there are
> 3 loops which add configs, and only one was updated
> to num_formats.
> 
> Also update loops for configs with accumulation buffer
> and multisample configs.
> 
> Fixes: 731ba6924a2 "i965: expose RGBA visuals only on Android"
> Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com>
> ---
>   src/mesa/drivers/dri/i965/intel_screen.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c
> index 655edd6..712cd40 100644
> --- a/src/mesa/drivers/dri/i965/intel_screen.c
> +++ b/src/mesa/drivers/dri/i965/intel_screen.c
> @@ -2028,7 +2028,7 @@ intel_screen_make_configs(__DRIscreen *dri_screen)
>      /* Generate the minimum possible set of configs that include an
>       * accumulation buffer.
>       */
> -   for (unsigned i = 0; i < ARRAY_SIZE(formats); i++) {
> +   for (unsigned i = 0; i < num_formats; i++) {
>         __DRIconfig **new_configs;
>   
>         if (formats[i] == MESA_FORMAT_B5G6R5_UNORM) {
> @@ -2060,7 +2060,7 @@ intel_screen_make_configs(__DRIscreen *dri_screen)
>       * supported.  Singlebuffer configs are not supported because no one wants
>       * them.
>       */
> -   for (unsigned i = 0; i < ARRAY_SIZE(formats); i++) {
> +   for (unsigned i = 0; i < num_formats; i++) {
>         if (devinfo->gen < 6)
>            break;
>   
>