[Mesa-dev] [PATCH 6/6] st/dri: implement createImageFromRenderbuffer(2)

Emil Velikov emil.l.velikov at gmail.com
Tue Oct 10 16:30:46 UTC 2017


On 6 October 2017 at 21:16, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>
> Tested with dEQP-EGL tests.

> +    .createImageWithModifiers     = NULL,
> +    .createImageFromDmaBufs2      = NULL,
> +    .queryDmaBufFormats           = NULL,
> +    .queryDmaBufModifiers         = NULL,
> +    .queryDmaBufFormatModifierAttribs = NULL,

One of the nice things about C99 initializers is that you don't need
these lines ;-)
Eric's got a good point through - please mention the set of tests and
flip the order of 5 and 6.

With the small nitpick with in 4/6 patches 1-4 are
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

I'll send some patches for the i965/!Gallium drivers as a follow-up.

Thanks
Emil


More information about the mesa-dev mailing list