[Mesa-dev] [PATCH 4/4] radv: remove duplicate line of code

Samuel Pitoiset samuel.pitoiset at gmail.com
Wed Oct 11 07:52:26 UTC 2017


Patches 1 and 4 are:

Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

On 10/11/2017 06:11 AM, Timothy Arceri wrote:
> The same line of code is a few lines above.
> ---
>   src/amd/vulkan/radv_pipeline_cache.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_pipeline_cache.c b/src/amd/vulkan/radv_pipeline_cache.c
> index bced425966..714edf03a4 100644
> --- a/src/amd/vulkan/radv_pipeline_cache.c
> +++ b/src/amd/vulkan/radv_pipeline_cache.c
> @@ -184,21 +184,20 @@ radv_create_shader_variant_from_pipeline_cache(struct radv_device *device,
>   
>   		variant = calloc(1, sizeof(struct radv_shader_variant));
>   		if (!variant)
>   			return NULL;
>   
>   		variant->code_size = entry->code_size;
>   		variant->config = entry->config;
>   		variant->info = entry->variant_info;
>   		variant->rsrc1 = entry->rsrc1;
>   		variant->rsrc2 = entry->rsrc2;
> -		variant->code_size = entry->code_size;
>   		variant->ref_count = 1;
>   
>   		void *ptr = radv_alloc_shader_memory(device, variant);
>   		memcpy(ptr, entry->code, entry->code_size);
>   
>   		entry->variant = variant;
>   	}
>   
>   	p_atomic_inc(&entry->variant->ref_count);
>   	return entry->variant;
> 


More information about the mesa-dev mailing list