[Mesa-dev] [PATCH 4/6] i965: Add blorp-based texture upload path

[Kenneth Graunke]

On Wednesday, October 11, 2017 8:40:52 AM PDT Jason Ekstrand wrote:
> On Tue, Oct 10, 2017 at 3:14 PM, Kenneth Graunke <kenneth at whitecape.org>
> wrote:
> 
> > From: Topi Pohjolainen <topi.pohjolainen at intel.com>
> >
> > v2:
> >    - Fix return value (s/MESA_FORMAT_NONE/false/) (Anuj)
> >    - Move _mesa_tex_format_from_format_and_type() just
> >      in the end avoiding additional if-block (Anuj)
> >    - Explain better the array alignment restriction (Anuj)
> >    - Do not bail out in case of gl_pixelstore_attrib::ImageHeight,
> >      it is handled by _mesa_image_offset() automatically (Ken).
> >    - Support 1D_ARRAY by flipping depth, width and y, z (Ken).
> >
> > v3:
> >    - Contrary to v2, do not try to handle
> >      gl_pixelstore_attrib::ImageHeight. Currently there are no
> >      tests in piglit or cts for it. One could possibly copy or
> >      modify tests/texturing/texsubimage.c. There, however, seems
> >      to be number of corner cases to consider. Moreover, current
> >      meta path applies the packing height for both source and
> >      targets when determining the offset. This would probably
> >      require re-visiting also.
> >
> > v4: Rebased on top of merged drm-bacon
> >
> > v5 (Jason Ekstrand):
> >    - Move to brw_blorp.c
> >    - Significant refactoring
> >    - Fixed 1-D array textures
> >    - Simplified handling of PBOs vs. CPU data.
> >    - Handle gl_pixelstore_attrib::ImageHeight.  It turns out there are
> >      piglit tests that cover this. The original version was failing them
> >      because of an error in the way it handled 1-D array textures.
> >    - Add support for texture download
> >
> > v6 (Ken): Rebase fixes:
> >    - Use intel_miptree_check_level_layer instead of deleted fields
> >    - Update for mesa_format_supports_render[] rename.
> >    - Pass 'false' (read-only) to intel_bufferobj_buffer
> >
> 
> Why pass false instead of !read_only?

Blindness...I didn't see the parameter.  Fixed on my 'tex-upload' and
'blorp-tex' branches.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171011/961f296d/attachment-0001.sig>