[Mesa-dev] [Mesa-stable] [PATCH 1/2] anv: fix push descriptors with set > 0

Lionel Landwerlin lionel.g.landwerlin at intel.com
Thu Oct 12 17:27:45 UTC 2017


On 12/10/17 18:15, Emil Velikov wrote:
> On 6 October 2017 at 16:42, Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>> When writing to set > 0, we were just wrongly writing to set 0. This
>> commit fixes this by lazily allocating each set as we write to them.
>>
>> We didn't go for having them directly into the command buffer as this
>> would require an additional ~45Kb per command buffer.
>>
>> v2: Allocate push descriptors from system memory rather than in BO
>>      streams. (Lionel)
>>
>> Cc: "17.2 17.1" <mesa-stable at lists.freedesktop.org>
>> Fixes: 9f60ed98e501 ("anv: add VK_KHR_push_descriptor support")
>> Reported-by: Daniel Ribeiro Maciel <daniel.maciel at gmail.com>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
>> ---
> This and 2/2 have landed in master in slightly different form as
>
> d296dea54e243c41c2b3fbe631f7bcb87db6ae8c anv/cmd_buffer: fix push
> descriptors with set > 0
> 0763f814d7b5cb4da945d9211faab47e8523fdad anv/cmd_buffer: Reset state
> in cmd_buffer_destroy
>
> I've picked them up for 17.2.3
>
> Thanks
> Emil
>
Thanks!



More information about the mesa-dev mailing list