[Mesa-dev] [PATCH v2 40/52] i965/program: Move nir_lower_system_values higher up

[Lionel Landwerlin]

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 13/10/17 06:48, Jason Ekstrand wrote:
> We want this to get called before nir_lower_subgroups which is going in
> brw_preprocess_nir.  Now that nir_lower_wpos_ytransform can handle
> system values, this should be safe to do.
> ---
>   src/mesa/drivers/dri/i965/brw_program.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_program.c b/src/mesa/drivers/dri/i965/brw_program.c
> index 3b54b37..ebb6998 100644
> --- a/src/mesa/drivers/dri/i965/brw_program.c
> +++ b/src/mesa/drivers/dri/i965/brw_program.c
> @@ -89,6 +89,8 @@ brw_create_nir(struct brw_context *brw,
>   
>      nir = brw_preprocess_nir(brw->screen->compiler, nir);
>   
> +   NIR_PASS_V(nir, nir_lower_system_values);
> +
>      if (stage == MESA_SHADER_FRAGMENT) {
>         static const struct nir_lower_wpos_ytransform_options wpos_options = {
>            .state_tokens = {STATE_INTERNAL, STATE_FB_WPOS_Y_TRANSFORM, 0, 0, 0},
> @@ -104,7 +106,6 @@ brw_create_nir(struct brw_context *brw,
>         }
>      }
>   
> -   NIR_PASS_V(nir, nir_lower_system_values);
>      NIR_PASS_V(nir, brw_nir_lower_uniforms, is_scalar);
>   
>      return nir;