[Mesa-dev] [PATCH v1] clover/llvm: Drop support for LLVM < 3.9.

Emil Velikov emil.l.velikov at gmail.com
Fri Oct 13 13:11:46 UTC 2017


Hi Vedran,

Just pushed the LLVM version bump, so this patch should be able to go in.
I won't be able to offer any review here, apart from a small suggestion.

On 9 October 2017 at 00:08, Vedran Miletić <vedran at miletic.net> wrote:

>  #include <clang/Basic/TargetInfo.h>
>  #include <clang/Frontend/CodeGenOptions.h>
> @@ -63,11 +56,7 @@
>  namespace clover {
>     namespace llvm {
>        namespace compat {
> -#if HAVE_LLVM >= 0x0307
>           typedef ::llvm::TargetLibraryInfoImpl target_library_info;
> -#else
> -         typedef ::llvm::TargetLibraryInfo target_library_info;
> -#endif
>
With the guards gone, one should be able to remove/inline compat stuff
like this.
Not sure how much it matters or if one isn't going to need anyway for
newer LLVM.

-Emil


More information about the mesa-dev mailing list