[Mesa-dev] [PATCH 1/2] meson: provide Makefile.sources variables to meson build

[Dylan Baker]

Quoting Jakob Bornecrantz (2017-10-14 13:03:14)
> On Sat, Oct 14, 2017 at 1:36 AM, Dylan Baker <dylan at pnwbakers.com> wrote:
> > I'm not sure about this approach, we would need a way to add depends to meson,
> > but I'm also worried that calling make adds another dependency that could be
> > problematic for windows, and I really don't like the idea of having a
> > half-and-half approach with the sources.
> >
> > Here's what I've been playing with:
> > https://github.com/dcbaker/meson/tree/make-import-module
> > https://github.com/dcbaker/mesa/tree/wip/meson-makefile-sources
> >
> > How would you feel about that?
> 
> Couldn't you just use the Makefile parser José wrote for the scons
> build, that would avoid running make and waiting for a new version of
> Meson. Or is there something it is lacking?
> 
> We could start out with our own Makefile parser and then move onto one
> in Meson once it is upstreamed and that version of meson is commonly
> available?
> 
> Cheers, Jakob.

In the short term I don't know how much it really hurts to duplicate the sources
in meson vs reading the makefiles, I also haven't had a chance to look at what
Jose did in scons, but if upstreaming fails that is probably a good starting
point. I'd like to try to get something upstream rather than hacking around
meson, since that has been very successful in the past. I should also point out
that meson's LLVM handling is due for a pretty major overhaul (patches waiting
more review and merge), and that we really want that support anyway (among other
things meson's LLVM inserts -L/usr/lib into your linker args, and as of 0.43
lacks static/dynamic linking options. There are also some features that are in
0.43 (we currently support back to at least 0.42, I haven't tested further back
than that) that we will need to work on windows (our workarounds involve using
touch). There's also still a lot of work to do to get our meson build system up
to the quality of our autotools and scons build systems, so I think we have some
time before we need to worry really hard about it.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171014/adaba491/attachment.sig>