[Mesa-dev] Testing out Kristian's fast mtx patch

Timothy Arceri tarceri at itsqueeze.com
Mon Oct 16 00:17:09 UTC 2017



On 10/10/17 23:38, Marek Olšák wrote:
> 
> 
> On Oct 10, 2017 4:46 AM, "Timothy Arceri" <tarceri at itsqueeze.com 
> <mailto:tarceri at itsqueeze.com>> wrote:
> 
>     After a recent discussion about this code from 2015 I was curious
>     to give it a try. The outstanding review item was that we shouldn't
>     be replacing the C11 mtx type/functions with our own, so I've renamed
>     the fast path to simple_mtx* and added a couple of patches to make use
>     of it.
> 
>     The idea is this fast mtx can be used in place of the full mtx
>     implementation when its of type mtx_plain.
> 
> 
> Thanks for picking this up!
> 
> I think all our mutexes are mtx_plain, but the simple mutexes can't be 
> used with cond vars.

Yeah this is unfortunate, presumably this could have been helpful for 
glthread etc.

> 
> Marek
> 
> 
>     I though if anywhere we might see a change in the drawoverhead piglit
>     test but I didn't see any real change.
> 
>     Anyway since I've made the updates I thought I'd send it out. Maybe
>     someone else might find some better results. Kristian reported a 10%
>     increase in some internal Intel benchmarks, I wonder if thats still the
>     case.
> 
>     _______________________________________________
>     mesa-dev mailing list
>     mesa-dev at lists.freedesktop.org <mailto:mesa-dev at lists.freedesktop.org>
>     https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>     <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>
> 
> 


More information about the mesa-dev mailing list