[Mesa-dev] [PATCH] st/va: Disable vaExportSurfaceHandle()

[Christian König]

Am 15.10.2017 um 22:11 schrieb Mark Thompson:
> This is not in libva 2.0, so it shouldn't be enabled yet.
>
> Signed-off-by: Mark Thompson <sw at jkqxz.net>
> ---
> On 15/10/17 20:06, Leo Liu wrote:
>> On 2017-10-15 07:23 AM, Mark Thompson wrote:
>>> This reverts commit c4ed39f85b1ebd062eaa51880fcc79cfbcb4e5c3.
>> Can we just leave the code there, and gated by "#if 0" for now? so it would be easier for testing purpose.
> Sure; alternative patch enclosing.  (I was mostly thinking that people might prefer not to have the disabled code appearing in releases, but if that's fine then this is indeed more convenient for testing.)

I agree with Leo that this is the better approach.

Feel free to add my Acked-by to the patch.

BTW: Mark if you don't have commit rights yet, feel free to request 
them. I and I think Leo as well will certainly support that.

Regards,
Christian.

> Thanks,
>
> - Mark
>
>
>   src/gallium/state_trackers/va/context.c | 2 +-
>   src/gallium/state_trackers/va/surface.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/state_trackers/va/context.c b/src/gallium/state_trackers/va/context.c
> index 1207499a78..78e1f19ab7 100644
> --- a/src/gallium/state_trackers/va/context.c
> +++ b/src/gallium/state_trackers/va/context.c
> @@ -89,7 +89,7 @@ static struct VADriverVTable vtable =
>      &vlVaQuerySurfaceAttributes,
>      &vlVaAcquireBufferHandle,
>      &vlVaReleaseBufferHandle,
> -#if VA_CHECK_VERSION(1, 0, 0)
> +#if 0
>      &vlVaExportSurfaceHandle,
>   #endif
>   };
> diff --git a/src/gallium/state_trackers/va/surface.c b/src/gallium/state_trackers/va/surface.c
> index 76e562717a..ccdeabc3ad 100644
> --- a/src/gallium/state_trackers/va/surface.c
> +++ b/src/gallium/state_trackers/va/surface.c
> @@ -903,7 +903,7 @@ vlVaQueryVideoProcPipelineCaps(VADriverContextP ctx, VAContextID context,
>      return VA_STATUS_SUCCESS;
>   }
>   
> -#if VA_CHECK_VERSION(1, 0, 0)
> +#if 0
>   VAStatus
>   vlVaExportSurfaceHandle(VADriverContextP ctx,
>                           VASurfaceID surface_id,