[Mesa-dev] [PATCH v3 02/21] configure: commit test files

[Emil Velikov]

On 13 October 2017 at 23:05, Dylan Baker <dylan at pnwbakers.com> wrote:
> These are currently auto-generated, but meson needs the same files, so
> lets commit them to reduce duplication.
>
> v3: - Rename .build to build-support
>
> cc:  Emil Velikov <emil.l.velikov at gmail.com>
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>

Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thank you. There's a small clarification below, feel free to ignore.

> ---
>
> I ran make dist and that works (after patching out the swr llvm 3.9 check). I
> alos built that tarball and the build succeeded.
To clear up some confusion, distcheck should, amongst others:
 a) create tarballs
 b) extract tarball FOO
 - annotate srcdir as read only
 - build out of tree
 - install to custom prefix
 - uninstall, check for dangling files
 - re-create tarballs
 c) compare tarballs (not 100% sure on this one)

What I'm trying to say is - building from the distcheck tarball might
have been an overkill.
Regardless, thank you for being thorough.

-Emil