[Mesa-dev] [RFC v4 08/23] egl/x11: Re-allocate buffers if format is suboptimal

Emil Velikov emil.l.velikov at gmail.com
Mon Oct 16 14:12:50 UTC 2017


On 16 October 2017 at 14:12, Eric Engestrom <eric.engestrom at imgtec.com> wrote:

>> +               if (draw->buffers[b])
>> +                  draw->buffers[b]->realloc_suboptimal = true;
>> +            }
>>              break;
>>           case XCB_PRESENT_COMPLETE_MODE_COPY:
>>              draw->flipping = false;
>>              break;
>> +#if XCB_PRESENT_MAJOR_VERSION > 1 || (XCB_PRESENT_MAJOR_VERSION == 1 && XCB_PRESENT_MINOR_VERSION >= 1)
>
> shouldn't that be a be a runtime check?
>
Eric, the idea is that we'll swap these with a version bump, once
people are happy with the interfaces.

Any form of build/runtime version check is going to end badly.
Emil


More information about the mesa-dev mailing list