[Mesa-dev] [PATCH] svga: fix format_conversion_table breakage

[Brian Paul]

On 10/16/2017 08:07 AM, Emil Velikov wrote:
> On 16 October 2017 at 11:24, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
>> On Saturday, 2017-10-14 16:52:29 +0000, Brian Paul wrote:
>>> The new A1B5G5R5_UNORM, X1B5G5R5_UNORM formats were added in the
>>> wrong place
>>
>> Can you explain why this was wrong, so that one doesn't make the same
>> mistake next time? Maybe add that as a comment atop the array?
>> (Is it a simple case of "always add at the end" or is there more to it?)
>>
> I've skimmed through the patch as it flew by, but I misread the
> vgpu10_format_entry::pformat as a C99 initializer.
> Might be worth doing that as a follow-up - it should prevent these
> kind of explosions.
>
> Plus it will make the table shorter as the invalid entries can be
> omitted (I think)

I can look at doing that in a follow-on commit.  I'm pretty sure we can 
do that with MSVC now.

R-b?

-Brian

>
>>> in commit ef874ee450b18e "gallium: Add support for 5551
>>> with the 1-bit field in the low bit."
>>
>> Fixes: ef874ee450b18e "gallium: Add support for 5551 with the 1-bit field in the low bit."
>>
>> (so that scripts pick it up)
>>
> Yes please.
>
> Thanks
> Emil
>