[Mesa-dev] [PATCH] egl/wayland: Support for KHR_partial_update

[Emil Velikov]

On 16 October 2017 at 16:21, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> On Monday, 2017-10-16 14:29:02 +0000, Emil Velikov wrote:
>> On 13 October 2017 at 19:49, Harish Krupo <harish.krupo.kps at intel.com> wrote:
>> > This passes 33/37 deqp tests related to partial_update, 4 are not
>> > supported.
>> >
>> Mildly related:
>> Android's .swap_buffers_with_damage seems to be missing. AFAICT should
>> be able to implement it via droid_set_damage_region?
>
> It's actually handled through dri2_fallback_swap_buffers_with_damage()
> which does a set_damage_region() + swap_buffers(),
Thanks, should have looked before commenting :-\

> but IIRC when
> I suggested to explicitly advertise its support in android's extension
> string, it was declined as android's egl wrapper already handles it [1],
> so it mesa's code won't be used anyway.
>
It's a bit strange that Android would implement
eglSwapBuffersWithDamage* and not eglSetDamageRegionKHR.
I wonder if adding a comment/link beside the .swap_buffers_with_damage
line would spare a silly suggestion like mine in the future ;-)

-Emil