[Mesa-dev] [PATCH] egl/android: add a note about .swap_buffers_with_damage

[Eric Engestrom]

On Monday, 2017-10-16 16:10:42 +0000, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Android implements the API and does the native damage handling itself.
> At the same time it
>  a) does call the vendor's eglSwapBuffersWithDamageKHR
>  b) does not implement eglSetDamageRegionKHR
> 
> There's something strange happening here. For now simply note about the
> 'lack' of eglSwapBuffersWithDamageKHR support.
> 
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

> ---
>  src/egl/drivers/dri2/platform_android.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c
> index e390365b8bb..63223e9a69f 100644
> --- a/src/egl/drivers/dri2/platform_android.c
> +++ b/src/egl/drivers/dri2/platform_android.c
> @@ -1088,7 +1088,7 @@ static const struct dri2_egl_display_vtbl droid_display_vtbl = {
>     .destroy_surface = droid_destroy_surface,
>     .create_image = droid_create_image_khr,
>     .swap_buffers = droid_swap_buffers,
> -   .swap_buffers_with_damage = dri2_fallback_swap_buffers_with_damage,
> +   .swap_buffers_with_damage = dri2_fallback_swap_buffers_with_damage, /* Android implements the function */
>     .swap_buffers_region = dri2_fallback_swap_buffers_region,
>  #if ANDROID_API_LEVEL >= 23
>     .set_damage_region = droid_set_damage_region,
> -- 
> 2.14.1
>