[Mesa-dev] [PATCH 06/10] gbm: remove incorrect DRIImage version check in gbm_dri_bo_import()

[Jakob Bornecrantz]

On Mon, Oct 16, 2017 at 5:04 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> The version of the extension does not imply success for the
> queryImage(... WIDTH/HEIGHT ...) calls.
>
> With that properly handled (as of last commit), we can drop the check.
>
> Fixes: 93ebec87ed4 ("dri: Make query image WIDTH and HEIGHT be version 4")
> Cc: Jakob Bornecrantz <jakob.bornecrantz at collabora.co.uk>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

Reviewed-by: Jakob Bornecrantz <jakob.bornecrantz at collabora.com>

Cheers, Jakob.

> ---
>  src/gbm/backends/dri/gbm_dri.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
> index a6c80cf1ec7..d7cf01fc6b4 100644
> --- a/src/gbm/backends/dri/gbm_dri.c
> +++ b/src/gbm/backends/dri/gbm_dri.c
> @@ -893,8 +893,7 @@ gbm_dri_bo_import(struct gbm_device *gbm,
>     int gbm_format;
>     unsigned query; /* EGLBoolean, but we cannot include the header */
>
> -   /* Required for query image WIDTH & HEIGHT */
> -   if (dri->image == NULL || dri->image->base.version < 4) {
> +   if (dri->image == NULL) {
>        errno = ENOSYS;
>        return NULL;
>     }
> --
> 2.14.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev