[Mesa-dev] [PATCH 09/10] anv: Implement VK_ANDROID_native_buffer (v9)

Chad Versace chadversary at chromium.org
Mon Oct 16 22:16:41 UTC 2017


On Mon 16 Oct 2017, Kristian Høgsberg wrote:
> On Mon, Oct 16, 2017 at 11:55 AM, Chad Versace <chadversary at chromium.org> wrote:

> > v9:
> >   - Isolate as much Android code as possible, moving it from anv_image.c
> >     to anv_android.c. Connect the files with anv_image_from_gralloc().
> >     Remove VkNativeBufferANDROID params from all anv_image.c
> >     funcs. [for krh]
> 
> Looks great now, very clean.

All thanks to your suggestions last week.

> 
> >   - Replace some intel_loge() with vk_errorf() in anv_android.c.
> >   - Use © in copyright line. [for krh]
> 
> Last nit-pick: It's "Google, Inc."
> 
> With that,
> 
> Reviewed-by: Kristian H. Kristensen <hoegsberg at google.com>

Thanks for taking a look.


More information about the mesa-dev mailing list