[Mesa-dev] [PATCH v2 03/52] intel/fs: Handle flag read/write aliasing in needs_src_copy

Matt Turner mattst88 at gmail.com
Tue Oct 17 19:04:01 UTC 2017


On 10/12, Jason Ekstrand wrote:
>In order to implement the ballot intrinsic, we do a MOV from flag
>register to some GRF.  If that GRF is used in a SEL, cmod propagation
>helpfully changes it into a MOV from the flag register with a cmod.
>This is perfectly valid but when lower_simd_width comes along, it simply
>splits into two instructions which both have conditional modifiers.
>This is a problem since we're reading the flag register.  This commit
>makes us check whether or not flags_written() overlaps with the flag
>values that we are reading via the instruction source and, if we have
>any interference, will force us to emit a copy of the source.
>
>Cc: mesa-stable at lists.freedesktop.org

Reviewed-by: Matt Turner <mattst88 at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171017/0b008b18/attachment-0001.sig>


More information about the mesa-dev mailing list