[Mesa-dev] [PATCH v3 02/43] mesa/st: Handle 16-bit types at st_glsl_storage_type_size()

Nicolai Hähnle nhaehnle at gmail.com
Tue Oct 17 19:36:11 UTC 2017


Patches 1 & 2:

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

On 12.10.2017 20:37, Jose Maria Casanova Crespo wrote:
> From: Eduardo Lima Mitev <elima at igalia.com>
> 
> This is basically to avoid "not handle in switch" warnings.
> 
> v2: Let the new types hit the assertion instead. (Marek Olšák
>      and Jason Ekstrand)
> 
> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
> ---
>   src/mesa/state_tracker/st_glsl_types.cpp | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/src/mesa/state_tracker/st_glsl_types.cpp b/src/mesa/state_tracker/st_glsl_types.cpp
> index 50936025d9..e57fbc8f31 100644
> --- a/src/mesa/state_tracker/st_glsl_types.cpp
> +++ b/src/mesa/state_tracker/st_glsl_types.cpp
> @@ -98,6 +98,9 @@ st_glsl_storage_type_size(const struct glsl_type *type, bool is_bindless)
>      case GLSL_TYPE_VOID:
>      case GLSL_TYPE_ERROR:
>      case GLSL_TYPE_FUNCTION:
> +   case GLSL_TYPE_FLOAT16:
> +   case GLSL_TYPE_UINT16:
> +   case GLSL_TYPE_INT16:
>         assert(!"Invalid type in type_size");
>         break;
>      }
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.


More information about the mesa-dev mailing list