[Mesa-dev] [Bug 103323] Possible unintended error message in file pixel.c line 286

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=103323

            Bug ID: 103323
           Summary: Possible unintended error message in file pixel.c line
                    286
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Mesa core
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: petrum at gmail.com
        QA Contact: mesa-dev at lists.freedesktop.org

While experimenting with a CodeSonar plugin we develop, we noticed a potential
bug in file "src/mesa/main/pixel.c" line 286 (function _mesa_PixelMapusv).

if (map >= GL_PIXEL_MAP_S_TO_S && map <= GL_PIXEL_MAP_I_TO_A) {
      /* test that mapsize is a power of two */
      if (!_mesa_is_pow_two(mapsize)) {
         _mesa_error( ctx, GL_INVALID_VALUE, "glPixelMapuiv(mapsize)" ); //HERE
         return;
      }
}

Shouldn't the error message be "glPixelMapu>s<v(mapsize)" insead of
"glPixelMapu>i<v(mapsize)"? In other words, shouldn't the 12th character be 's'
instead of 'i' in the error message?

Thanks,
Petru Mihancea

Note: The problem has been detected automatically via static analysis.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171018/bf80792a/attachment.html>