[Mesa-dev] [PATCH] egl/dri2: disambiguate driver name

[Eric Engestrom]

On Wednesday, 2017-10-18 15:32:20 +0000, Kai Wasserbäch wrote:
> Hey Eric,
> Eric Engestrom wrote on 17.10.2017 19:48:
> > On Tuesday, 2017-10-17 17:20:13 +0000, Emil Velikov wrote:
> >> [...]
> >> Yes name is a bit misleading, so I'm wondering if any of the following
> >> won't be better
> >>  - s/DRI2/DRI/ - might be tad confusing
> >>  - emit the corresponding DRI2 vs DRI3 - ideally, but might be fiddly
> >> to get sorted
> >>  - drop DRI2 all together - the other backends (glx yes glx and
> >> gallium) are long gone
> >>
> >> What do you guys think?
> >> Emil
> > 
> > I vote remove. The only alternative is Haiku, and one would know if
> > that's what they were running.
> > I feel like this is part of the whole driver refactor ajax did in
> > b174a1ae720cb404738c "egl: Simplify the "driver" interface"
> > 
> > I'll send a patch removing the whole `name` thing tomorrow, if Kai
> > doesn't beat me to it :P
> 
> I doubt that, since removing the Name field from _egl_driver would leave just
> the _EGLAPI in it, which should mean, one could remove _egl_driver entirely.

I noticed that too, but it would be a lot of churn (almost all the
functions take an _EGLDriver, 300+ of those) and not much gain, so I'll
leave it for now. I'll talk to Emil about it :)

> Which is a bit more work than I have time for in the evenings at the moment. I
> could maybe look at it on Sunday. But I'd hazard a guess, that you'd be way
> faster than that. So feel free to send that patch.

I actually did it since I didn't see anything from you earlier this
afternoon (UK), and then sent it without checking the list again, so
I only just noticed your message :)

> 
> Cheers,
> Kai
>