[Mesa-dev] [PATCH] radv: reset dirty flags after flushing all states

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Wed Oct 18 18:53:34 UTC 2017


r-b

On Wed, Oct 18, 2017 at 2:09 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Move it to radv_cmd_buffer_flush_state() because if
> rasterizerDiscardEnable is true, the flags are not cleared.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index f2e8c0ca5a..147235006f 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -1477,8 +1477,6 @@ radv_cmd_buffer_flush_dynamic_state(struct radv_cmd_buffer *cmd_buffer)
>         if (cmd_buffer->state.dirty & (RADV_CMD_DIRTY_PIPELINE |
>                                        RADV_CMD_DIRTY_DYNAMIC_DEPTH_BIAS))
>                 radv_emit_depth_biais(cmd_buffer);
> -
> -       cmd_buffer->state.dirty = 0;
>  }
>
>  static void
> @@ -1789,6 +1787,8 @@ radv_cmd_buffer_flush_state(struct radv_cmd_buffer *cmd_buffer,
>         assert(cmd_buffer->cs->cdw <= cdw_max);
>
>         si_emit_cache_flush(cmd_buffer);
> +
> +       cmd_buffer->state.dirty = 0;
>  }
>
>  static void radv_stage_flush(struct radv_cmd_buffer *cmd_buffer,
> --
> 2.14.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list