[Mesa-dev] [PATCH 2/2] radv: do not re-emit the index buffer for every draw call

[Samuel Pitoiset]

On 10/18/2017 09:54 PM, Dave Airlie wrote:
> On 19 October 2017 at 04:56, Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl> wrote:
>> Interesting that we already had RADV_CMD_DIRTY_INDEX_BUFFER. r-b for the series.
>>
>> On Wed, Oct 18, 2017 at 2:17 PM, Samuel Pitoiset
>> <samuel.pitoiset at gmail.com> wrote:
>>> It can only be changed when CmdBindIndexBuffer() is called
>>> or when a secondary buffer is used. Though not always, but
>>> let's re-emit the packets in this situation for now.
> 
> There is some hw issue around resetting the index type that my brain
> can't come up with,
> 
> /* On CI and later, non-indexed draws overwrite VGT_INDEX_TYPE,
>   * so the state must be re-emitted before the next indexed draw.
>   */
> 
> Just make sure we still do the right thing here before pushing.

Mmmh, I have pushed the patch already, I'm going to have a look.

> 
> Dave.
>