[Mesa-dev] [PATCH] radv: fix CLEAR_STATE packet length.

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Thu Oct 19 08:09:38 UTC 2017


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Thu, Oct 19, 2017 at 5:54 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> Looking at shader traces I noticed some registers were missing,
> one of them was being eaten by the wrong clear state length.
>
> Fixes: 4f42ea4dc (radv: use CLEAR_STATE for initializing some registers)
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/si_cmd_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
> index 1e8b43d4fa8..690f30b6abc 100644
> --- a/src/amd/vulkan/si_cmd_buffer.c
> +++ b/src/amd/vulkan/si_cmd_buffer.c
> @@ -341,7 +341,7 @@ si_emit_config(struct radv_physical_device *physical_device,
>         radeon_emit(cs, CONTEXT_CONTROL_SHADOW_ENABLE(1));
>
>         if (physical_device->has_clear_state) {
> -               radeon_emit(cs, PKT3(PKT3_CLEAR_STATE, 1, 0));
> +               radeon_emit(cs, PKT3(PKT3_CLEAR_STATE, 0, 0));
>                 radeon_emit(cs, 0);
>         }
>
> --
> 2.14.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list