[Mesa-dev] [PATCH] radv: don't flush the VS when srcStageMask == TOP_OF_PIPE_BIT

[Samuel Pitoiset]

Thanks, pushed!

On 10/19/2017 09:09 PM, Bas Nieuwenhuizen wrote:
> Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
> 
> On Thu, Oct 19, 2017 at 8:54 PM, Fredrik Höglund <fredrik at kde.org> wrote:
>> The Vulkan specification says:
>>
>>     "... an execution dependency with only VK_PIPELINE_STAGE_TOP_OF_-
>>      PIPE_BIT in the source stage mask will effectively not wait for
>>      any prior commands to complete."
>>
>> Signed-off-by: Fredrik Höglund <fredrik at kde.org>
>> ---
>>   src/amd/vulkan/radv_cmd_buffer.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
>> index 147235006fa..4b9d49cd2bd 100644
>> --- a/src/amd/vulkan/radv_cmd_buffer.c
>> +++ b/src/amd/vulkan/radv_cmd_buffer.c
>> @@ -1813,8 +1813,7 @@ static void radv_stage_flush(struct radv_cmd_buffer *cmd_buffer,
>>                                VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT |
>>                                VK_PIPELINE_STAGE_ALL_COMMANDS_BIT)) {
>>                  cmd_buffer->state.flush_bits |= RADV_CMD_FLAG_PS_PARTIAL_FLUSH;
>> -       } else if (src_stage_mask & (VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT |
>> -                                    VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT |
>> +       } else if (src_stage_mask & (VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT |
>>                                       VK_PIPELINE_STAGE_VERTEX_INPUT_BIT |
>>                                       VK_PIPELINE_STAGE_VERTEX_SHADER_BIT)) {
>>                  cmd_buffer->state.flush_bits |= RADV_CMD_FLAG_VS_PARTIAL_FLUSH;
>> --
>> 2.11.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>