[Mesa-dev] [PATCH v2] egl/wayland: Support for KHR_partial_update

Emil Velikov emil.l.velikov at gmail.com
Fri Oct 20 13:17:23 UTC 2017


On 20 October 2017 at 12:35, Harish Krupo <harish.krupo.kps at intel.com> wrote:

> +   else if (!n_rects || !try_damage_buffer(dri2_surf, rects, n_rects))
>        wl_surface_damage(dri2_surf->wl_surface_wrapper,
>                          0, 0, INT32_MAX, INT32_MAX);
>
Please add a comment why SetDamageRegionCalled is honoured in the
SwapBuffers case, while it's not for SwapBuffersWithDamage(...NULL,
0);
Both functions should behave identically although one could interpret
the KHR_partial_update spec in different ways.

Also swap the hunk with:

else dri2_wl_set_damage_region(....);

Thanks
Emil


More information about the mesa-dev mailing list