[Mesa-dev] [PATCH 2/3] radv: Keep RADV_CMD_DIRTY_INDEX_BUFFER.

[Samuel Pitoiset]

On 10/21/2017 06:25 PM, Bas Nieuwenhuizen wrote:
> Otherwise for non-indexed draws we set and immediately unset it.
> 
> Fixes: 341529dbee5 'radv: use optimal packet order for draws'
> ---
>   src/amd/vulkan/radv_cmd_buffer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 887b789df87..dc8e037dbd3 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -3152,7 +3152,7 @@ radv_emit_all_graphics_states(struct radv_cmd_buffer *cmd_buffer,
>   				 info->instance_count > 1, info->indirect,
>   				 info->indirect ? 0 : info->count);
>   
> -	cmd_buffer->state.dirty = 0;
> +	cmd_buffer->state.dirty &= RADV_CMD_DIRTY_INDEX_BUFFER;

This is actually not needed, I think I messed up my rebase. Now, all 
dirty flags are cleared in the relevant emit helpers.

So, cmd_buffer->state.dirty = 0; should be removed.

>   }
>   
>   static void
>