[Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

Emil Velikov emil.l.velikov at gmail.com
Mon Oct 23 15:36:58 UTC 2017


On 23 October 2017 at 11:50, Harish Krupo <harish.krupo.kps at intel.com> wrote:
> This passes 33/37 deqp tests related to partial_update, 4 are not
> supported. Tests not supported:
> dEQP-EGL.functional.negative_partial_update.not_postable_surface
> dEQP-EGL.functional.negative_partial_update.not_current_surface
> dEQP-EGL.functional.negative_partial_update.buffer_preserved
> dEQP-EGL.functional.negative_partial_update.not_current_surface2
> Reason: No matching egl config found.
>
> v2: Remove unnecessary return statement. Keep function names
>     consistent.  (Emil Velikov)
>     Add not supported list to commit message. (Eric Engestrom)
>
> v3: Remove explicit with_damage variable. (Eric Engestrom)
>
Did you send the wrong version by any chance?
The summary does not reflect the actual changes.

Why did you rework try_damage_buffer into dri2_wl_set_damage_region?
It seems harder to follow over the previous patches.


> @@ -928,7 +944,8 @@ dri2_wl_query_buffer_age(_EGLDriver *drv,
>  static EGLBoolean
>  dri2_wl_swap_buffers(_EGLDriver *drv, _EGLDisplay *disp, _EGLSurface *draw)
>  {
> -   return dri2_wl_swap_buffers_with_damage(drv, disp, draw, NULL, 0);
> +   return dri2_wl_swap_buffers_with_damage(drv, disp, draw,
> +                                      NULL, 0);

Unrelated noop change.

Thanks
Emil


More information about the mesa-dev mailing list