[Mesa-dev] [PATCH] gallium/util: use util_snprintf() in u_socket_connect()

[Brian Paul]

On 10/24/2017 06:57 AM, Eric Engestrom wrote:
> On Monday, 2017-10-23 15:27:31 -0600, Brian Paul wrote:
>> Instead of plain snprintf().  To fix the MSVC build.
>>
>> snprintf() is used in various places in Mesa/gallium, but apparently,
>> not in code built with MSVC.
>
> Not sure I understand this sentence, but the patch is

snprintf() is used in various gallium drivers which are never compiled 
with MSVC, for example.

> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

Thanks.

-Brian

>> ---
>>   src/gallium/auxiliary/util/u_network.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/auxiliary/util/u_network.c b/src/gallium/auxiliary/util/u_network.c
>> index a7a4d28..203205d 100644
>> --- a/src/gallium/auxiliary/util/u_network.c
>> +++ b/src/gallium/auxiliary/util/u_network.c
>> @@ -2,6 +2,7 @@
>>   #include "pipe/p_compiler.h"
>>   #include "util/u_network.h"
>>   #include "util/u_debug.h"
>> +#include "util/u_string.h"
>>
>>   #include <stdio.h>
>>   #if defined(PIPE_SUBSYSTEM_WINDOWS_USER)
>> @@ -120,7 +121,7 @@ u_socket_connect(const char *hostname, uint16_t port)
>>      hints.ai_family = AF_UNSPEC; // AF_INET or AF_INET6 to force version
>>      hints.ai_socktype = SOCK_STREAM;
>>
>> -   snprintf(portString, sizeof(portString), "%d", port);
>> +   util_snprintf(portString, sizeof(portString), "%d", port);
>>
>>      r = getaddrinfo(hostname, portString, NULL, &addr);
>>      if (r != 0) {
>> --
>> 1.9.1
>>