[Mesa-dev] [PATCH] configure: Allow android as an EGL platform

[Eric Engestrom]

On Monday, 2017-10-23 15:39:48 -0600, Benjamin Gordon wrote:
> On Mon, Oct 23, 2017 at 11:10 AM, Eric Engestrom <eric.engestrom at imgtec.com>
> wrote:
> 
> > On Friday, 2017-10-20 15:34:57 -0600, Benjamin Gordon wrote:
> > > I'm working on radeonsi support in the Chrome OS Android container
> > > (ARC++).  Mesa in ARC++ uses autotools instead of Android.mk, but all
> > > the necessary EGL bits are there, so the existing check is too strict.
> > >
> > > Signed-off-by: Benjamin Gordon <bmgordon at chromium.org>
> >
> > Didn't double-check that all the android bits are wired, but I don't
> > think this can break anything outside android, so:
> > Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> >
> > Do you need someone to push this for you?
> >
> 
> Yes, please :)

Pushed! Congrats on your first patch :)

> 
> 
> >
> > > ---
> > >  configure.ac | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/configure.ac b/configure.ac
> > > index e05c34eb7b..b971b36333 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -2393,12 +2393,13 @@ dnl Surfaceless is an alternative for the last
> > one.
> > >  dnl
> > >  require_basic_egl() {
> > >      case "$with_platforms" in
> > > -        *drm*|*surfaceless*)
> > > +        *drm*|*surfaceless*|*android*)
> > >              ;;
> > >          *)
> > >              AC_MSG_ERROR([$1 requires one of these:
> > >                    1) --with-platforms=drm (X, Wayland, offscreen
> > rendering based on DRM)
> > >                    2) --with-platforms=surfaceless (offscreen only)
> > > +                  3) --with-platforms=android (Android only)
> > >                    Recommended options: drm,x11])
> > >              ;;
> > >      esac
> > > --
> > > 2.15.0.rc0.271.g36b669edcc-goog
> >                              ^^^^
> > Side note, do you guys have google builds of git?
> >
> 
> We probably do, but I'm afraid I don't have any idea what's in it.   There
> are several git contributors working here, so maybe stuff that they haven't
> finished upstreaming yet?