[Mesa-dev] [PATCH] Haiku: convert to autotools

Emil Velikov emil.l.velikov at gmail.com
Tue Oct 24 16:47:02 UTC 2017


Hi Jerome,

On 23 October 2017 at 16:58, Jerome Duval <jerome.duval at gmail.com> wrote:
> * configure.ac:
>   -pthread is not available on Haiku.
>   Haiku doesn't require --enable-dri
>   build hgl on Haiku
> * egl/Makefile.am: define backendfiles for Haiku
> * src/gallium/Makefile.am: build winsys/sw/hgl, state_trackers/hgl and
> targets/haiku-softpipe on Haiku.
> * src/gallium/targets/haiku-softpipe: add Makefile.am
> * src/gallium/state_trackers/hgl: add Makefile.am
> * winsys/sw/hgl: add Makefile.am
> * src/hgl/Makefile.am: add Makefile.am
> ---
Thanks for the patch. I think Eric has a point regarding splitting this up.
Here is one way to handle it:
 - patch 1 - the driver, aka st/hgl + sw/hgl + targets/haiku
 - 2 - src/egl
 - 3 - src/hgl
 - 4 misc fixes (the SoftwareRenderer.cpp hunk?)
 - 5 toggle - configure.ac + src/Makefile.am

Couple of small suggestions:
 - keep all the sources and headers in the sources lists in Makefile.sources
 - how do you guys manage pthreads - please mention that in the commit message.
If I'm reading this correctly, you strip out -pthread and there's no
pthread-stubs on Haiku.

-Emil


More information about the mesa-dev mailing list