[Mesa-dev] [PATCH] meson: add opt-out of libunwind

[Gert Wollny]

Am Dienstag, den 24.10.2017, 16:44 +0200 schrieb Erik Faye-Lund:
>  
>  dep_unwind = dependency('libunwind', required : false)
> -if dep_unwind.found()
> +if dep_unwind.found() and with_libunwind
>    pre_args += '-DHAVE_LIBUNWIND'
>  endif
Wouldn't it be better to do something like 

<<<
if with_libunwind
  dep_unwind = dependency('libunwind', required : false)
  if dep_unwind.found()
    pre_args += '-DHAVE_LIBUNWIND'
  endif
endif 
>>>

to avoid looking for the library altogether when it is disabled? 

One could even think about requiring libunwind if it is not explicitely
 disabled.

Best, 
Gert