[Mesa-dev] [PATCH v3 20/48] intel/fs: Protect opt_algebraic from OOB BROADCAST indices
Jason Ekstrand
jason at jlekstrand.net
Wed Oct 25 23:25:51 UTC 2017
---
src/intel/compiler/brw_fs.cpp | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/intel/compiler/brw_fs.cpp b/src/intel/compiler/brw_fs.cpp
index 1c4351b..52079d3 100644
--- a/src/intel/compiler/brw_fs.cpp
+++ b/src/intel/compiler/brw_fs.cpp
@@ -2416,8 +2416,14 @@ fs_visitor::opt_algebraic()
progress = true;
} else if (inst->src[1].file == IMM) {
inst->opcode = BRW_OPCODE_MOV;
- inst->src[0] = component(inst->src[0],
- inst->src[1].ud);
+ /* It's possible that the selected component will be too large and
+ * overflow the register. If this happens and we some how manage
+ * to constant fold it in and get here, it would cause an assert
+ * in component() below. Instead, just let it wrap around if it
+ * goes over exec_size.
+ */
+ const unsigned comp = inst->src[1].ud & (inst->exec_size - 1);
+ inst->src[0] = component(inst->src[0], comp);
inst->sources = 1;
inst->force_writemask_all = true;
progress = true;
--
2.5.0.400.gff86faf
More information about the mesa-dev
mailing list