[Mesa-dev] [PATCH 2/3] mesa: enable ARB_texture_buffer_* extensions in the Compatibility profile

[Dylan Baker]

I've pushed it to our CI, I'll let you know tomorrow what it looks like

Dylan

Quoting Marek Olšák (2017-10-25 19:52:43)
> Hi Dylan,
> 
> Can you please add this and re-test?
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c b/src/mesa/drivers/
> dri/i965/intel_extensions.c
> index 21cf632..4d17393 100644
> --- a/src/mesa/drivers/dri/i965/intel_extensions.c
> +++ b/src/mesa/drivers/dri/i965/intel_extensions.c
> @@ -178,7 +178,7 @@ intelInitExtensions(struct gl_context *ctx)
>        ctx->Extensions.ARB_pipeline_statistics_query = true;
>        ctx->Extensions.ARB_sample_shading = true;
>        ctx->Extensions.ARB_shading_language_420pack = true;
> -      if (ctx->API == API_OPENGL_CORE) {
> +      if (ctx->API != API_OPENGL_COMPAT) {
>           ctx->Extensions.ARB_texture_buffer_object = true;
>           ctx->Extensions.ARB_texture_buffer_object_rgb32 = true;
>           ctx->Extensions.ARB_texture_buffer_range = true;
> 
> 
> Marek
> 
> On Wed, Oct 25, 2017 at 11:42 PM, Dylan Baker <dylanx.c.baker at intel.com> wrote:
> 
>     There are a significant number of i965 regressions from
>     d96c68146a781c79a23f5181d7050174f1070d90, largely related to texturing (I
>     can
>     send you a complete list of regressions if you care, but due to the large
>     number
>     of them I suspect it's something fairly simple).
> 
>     For example:
>     ES31-CTS.functional.texture.format.buffer.r32ui_npot
> 
>     glGetIntegerv() failed: glGetError() returned GL_INVALID_ENUM at
>     gluContextInfo.cpp:229
> 
>     dEQP-GLES31.functional.state_query.integer.texture_buffer_
>     binding_getinteger:
> 
>     glGetIntegerv(GL_TEXTURE_BUFFER_BINDING, 0x00007ffee0c43834);
>     // data = { -555819298 }
>     glGetError();
>     // GL_INVALID_ENUM returned
>      // ERROR: glGetIntegerv: glGetError() returned GL_INVALID_ENUM
>    
>     Dylan
> 
>     Quoting Emil Velikov (2017-10-24 09:30:03)
>     > Hi Marek,
>     >
>     > On 21 October 2017 at 13:54, Marek Olšák <maraeo at gmail.com> wrote:
>     > > From: Marek Olšák <marek.olsak at amd.com>
>     > >
>     > > We already have piglit tests testing alpha, luminance, and intensity
>     > > formats. They were skipped by piglit until now.
>     > >
>     > > Additionally, I'm enabling one ARB_texture_buffer_range piglit test to
>     run
>     > > with the compat profile.
>     >
>     > Can you please mention that ARB_texture_buffer_* on i965 is unchanged
>     > - aka still enabled only for core profiles.
>     > Out of curiosity - can you tried the series with anything more than
>     piglit?
>     >
>     > The Intel guys can run the lot through CTS, dEQP... admittedly only on
>     > Intel hardware.
>     > Still it should help catch if a piece is missing somewhere.
>     >
>     >
>     > -Emil
>     > _______________________________________________
>     > mesa-dev mailing list
>     > mesa-dev at lists.freedesktop.org
>     > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171025/38ae09d3/attachment.sig>