[Mesa-dev] [PATCH 3/3] ac/llvm: drop pointless wrappers around umsb/imsb

[Timothy Arceri]

Series:

Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 26/10/17 16:31, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>   src/amd/common/ac_nir_to_llvm.c | 16 ++--------------
>   1 file changed, 2 insertions(+), 14 deletions(-)
> 
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 0167755..a736d34 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -1227,18 +1227,6 @@ static LLVMValueRef emit_bcsel(struct ac_llvm_context *ctx,
>   	return LLVMBuildSelect(ctx->builder, v, src1, src2, "");
>   }
>   
> -static LLVMValueRef emit_ifind_msb(struct ac_llvm_context *ctx,
> -				   LLVMValueRef src0)
> -{
> -	return ac_build_imsb(ctx, src0, ctx->i32);
> -}
> -
> -static LLVMValueRef emit_ufind_msb(struct ac_llvm_context *ctx,
> -				   LLVMValueRef src0)
> -{
> -	return ac_build_umsb(ctx, src0, ctx->i32);
> -}
> -
>   static LLVMValueRef emit_minmax_int(struct ac_llvm_context *ctx,
>   				    LLVMIntPredicate pred,
>   				    LLVMValueRef src0, LLVMValueRef src1)
> @@ -1871,11 +1859,11 @@ static void visit_alu(struct ac_nir_context *ctx, const nir_alu_instr *instr)
>   		break;
>   	case nir_op_ufind_msb:
>   		src[0] = ac_to_integer(&ctx->ac, src[0]);
> -		result = emit_ufind_msb(&ctx->ac, src[0]);
> +		result = ac_build_umsb(&ctx->ac, src[0], ctx->ac.i32);
>   		break;
>   	case nir_op_ifind_msb:
>   		src[0] = ac_to_integer(&ctx->ac, src[0]);
> -		result = emit_ifind_msb(&ctx->ac, src[0]);
> +		result = ac_build_imsb(&ctx->ac, src[0], ctx->ac.i32);
>   		break;
>   	case nir_op_uadd_carry:
>   		src[0] = ac_to_integer(&ctx->ac, src[0]);
>