[Mesa-dev] [PATCH] wayland-egl: forward declare wl_egl_window* functions

[Daniel Stone]

On 3 October 2017 at 14:34, Tobias Klausmann
<tobias.johannes.klausmann at mni.thm.de> wrote:
> Starting with commit ab0589c6ed ("wayland-egl: remove no longer needed
> wayland-client dependency") the wayland-egl.h include was missing leading to a
> build failure:
>
>   CC       wayland-egl.lo
> wayland-egl.c:33:10: fatal error: wayland-egl.h: No such file or directory
>  #include "wayland-egl.h"
>           ^~~~~~~~~~~~~~~
>
> This commit forward declares the following 4 functions from wayland-egl-core.h,
> as suggested by Andres Gomez:
>  * wl_egl_window_resize
>  * wl_egl_window_create
>  * wl_egl_window_destroy
>  * wl_egl_window_get_attached_size
>
> With this we can drop the wayland-egl.h include!

Looking back at previous threads, I'm not sure I'd call the split
'bonkers' - I mean, the whole point of Mesa is to provide an
implementation for a specification which only provides header files
with no C code - and we're not really close to doing a major Wayland
release where we'd begin to provide libwayland-egl.

Anyway, I'm sending a patch to Meson to fix this, which brings it into
line with the (fixed) autotools build. I guess Dylan took the
dependencies/flags from the autotools build when it was broken.

Cheers,
Daniel