[Mesa-dev] [PATCH 3/3] mesa: final changes to expose OpenGL 3.1 with ARB_compatibility

[Emil Velikov]

On 25 October 2017 at 20:11, Marek Olšák <maraeo at gmail.com> wrote:
> On Tue, Oct 24, 2017 at 6:37 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 21 October 2017 at 13:54, Marek Olšák <maraeo at gmail.com> wrote:
>>> From: Marek Olšák <marek.olsak at amd.com>
>>>
>>> ---
>>>  src/mesa/main/extensions_table.h |  1 +
>>>  src/mesa/main/mtypes.h           |  1 +
>>>  src/mesa/main/version.c          | 13 ++++++++-----
>>>  3 files changed, 10 insertions(+), 5 deletions(-)
>>>
>> Do we want to update src/mesa/drivers/dri/common/dri_util.c as well.
>> See the GL_ARB_compatibilty hunk in driCreateContextAttribs.
>
> Yes we can remove that.
>
In case I was vague, I think we should drop the whole hunk, as opposed
to just the comment

    /* Mesa does not support the GL_ARB_compatibilty extension or the
     * compatibility profile.  This means that we treat a
API_OPENGL_COMPAT 3.1 as
     * API_OPENGL_CORE and reject API_OPENGL_COMPAT 3.2+.
     */
    if (mesa_api == API_OPENGL_COMPAT && major_version == 3 &&
minor_version == 1)
       mesa_api = API_OPENGL_CORE;



>>
>> Can you please update docs/relnotes/17.4.0.html?
>
> Did you mean 18.0.0? :)
>
Yes, we're not 2018 yet :-P

Thanks
Emil