[Mesa-dev] [PATCH v2 1/8] Haiku: add src/hgl/Makefile.am and its pkgconfig file

[Emil Velikov]

On 24 October 2017 at 17:11, Jerome Duval <jerome.duval at gmail.com> wrote:

> +AM_CPPFLAGS = \
> +       -I$(top_srcdir)/src \
> +       -I$(top_srcdir)/src/mapi \
> +       -I$(top_srcdir)/src/mesa \
> +       -I$(top_srcdir)/src/mesa/main \
> +       -I$(top_srcdir)/include/ \
> +       -I$(top_srcdir)/include/HaikuGL \

> +       -I/system/develop/headers/private \
Is there a way to get this path at configure/build time?
Alternatively please add a small comment about it - "it will always
exist because..."/etc.

> +       -I$(top_builddir)/src/mapi \
Please keep the builddir before the respective srcdir.
Otherwise the stale generated file in srcdir will take precedence over
the pristine up-to date one in builddir

> +       $(DEFINES)
> +
> +
> +lib_LTLIBRARIES = libGL.la
> +
> +libGL_la_LIBADD = $(top_builddir)/src/mapi/glapi/libglapi.la -lbe
-lbe seems new wrt scons. Does this work on all supported Haiku platforms?
Please add a comment why one needs it.

> +libGL_la_SOURCES = $(COMMON_SOURCES)
> +libGL_la_LDFLAGS = \
> +       -no-undefined \
> +       -version-number 1:0 \
> +       $(BSYMBOLIC) \
> +       $(GC_SECTIONS) \
> +       $(LD_NO_UNDEFINED)
> +
> +pkgconfigdir = $(libdir)/pkgconfig
> +pkgconfig_DATA = gl.pc
> +
> +EXTRA_DIST =
Change that to EXTRA_DIST = SConscript
... unless you're planning to remove the scons bits.

Thanks
Emil