[Mesa-dev] [PATCH] meson: wayland-egl depends on wayland-client

[Daniel Stone]

Hi Eric,

On 26 October 2017 at 14:10, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> On Thursday, 2017-10-26 12:00:14 +0100, Daniel Stone wrote:
>>    'wayland-egl.c',
>>    c_args : [c_vis_args],
>>    link_args : ld_args_gc_sections,
>> +  dependencies : dep_wayland_client,
>
> Shouldn't that be `dep_wayland_server`?
> src/egl/wayland/wayland-egl/Makefile.am is using $WAYLAND_SERVER_CFLAGS
>
> I'll admit I don't fully understand what's wl client and what's wl
> server in mesa though, so I might be wrong.

Er, that seems weird. libwayland-egl is very definitely Wayland client
only. Not that it makes a difference, unless you go to the effort to
build the wayland source package twice and install them in different
locations ... but anyway. Flipping the automake build to use
WAYLAND_CLIENT_CFLAGS would arguably be more correct.

Cheers,
Daniel