[Mesa-dev] [PATCH 1/5] anv: add ETIME fallback define
emil.l.velikov at gmail.com
Thu Oct 26 14:02:52 UTC 2017
On 24 October 2017 at 18:21, Greg V <greg at unrelenting.technology> wrote:
> On 10/24/2017 20:16, Dylan Baker wrote:
>> Quoting Greg V (2017-10-23 13:20:39)
>>> FreeBSD only has ETIMEDOUT, not ETIME
>>> src/intel/vulkan/anv_device.c | 4 ++++
>>> src/intel/vulkan/anv_gem.c | 4 ++++
>>> src/intel/vulkan/anv_queue.c | 4 ++++
>>> 3 files changed, 12 insertions(+)
>>> diff --git a/src/intel/vulkan/anv_device.c
>>> index 67028e8da9..fab2a394ca 100644
>>> --- a/src/intel/vulkan/anv_device.c
>>> +++ b/src/intel/vulkan/anv_device.c
>>> @@ -39,6 +39,10 @@
>>> #include "genxml/gen7_pack.h"
>> I would add a comment here that this is for FreeBSD. Alternatively you
>> consider #ifdef __FreeBSD__ since it's self documenting.
> It's not just for FreeBSD, pretty much any non-Linux OS doesn't have ETIME.
Indeed the lack of ETIME (and ERESTART) is pretty wide-spread.
Greg, do you have any references why others (or FreeBSD at least)
haven't implemented it - say wiki page, discussion thread, etc?
I have no opinion on the patch, although it's strange to go through
patching both ends - userspace components and kernel(?).
More information about the mesa-dev