[Mesa-dev] [PATCH 2/2] anv: Fix assert about source attrs.

[Jason Ekstrand]

Rb to both


On October 26, 2017 18:38:52 Kenneth Graunke <kenneth at whitecape.org> wrote:

> Asserting slot >= 2 made sense when the URB read offset was always 1
> (pair of slots).  Commit 566a0c43f0b9fbf5106161471dd5061c7275f761 made
> it possible to read from the VUE header in slot 0, by adjusting the
> offset to be 0.  So, this assert is now bogus.  Use the one from GL.
> ---
>  src/intel/vulkan/genX_pipeline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/genX_pipeline.c 
> b/src/intel/vulkan/genX_pipeline.c
> index 326fc30dd31..7e3a785c584 100644
> --- a/src/intel/vulkan/genX_pipeline.c
> +++ b/src/intel/vulkan/genX_pipeline.c
> @@ -379,8 +379,8 @@ emit_3dstate_sbe(struct anv_pipeline *pipeline)
>           /* We have to subtract two slots to accout for the URB entry output
>            * read offset in the VS and GS stages.
>            */
> -         assert(slot >= 2);
>           const int source_attr = slot - 2 * urb_entry_read_offset;
> +         assert(source_attr >= 0 && source_attr < 32);
>           max_source_attr = MAX2(max_source_attr, source_attr);
>           swiz.Attribute[input_index].SourceAttribute = source_attr;
>        }
> --
> 2.14.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev