[Mesa-dev] [PATCH v3 00/10] glsl_to_tgsi: Further improvement of lifetime tracking for register merge

[Gert Wollny]

Am Donnerstag, den 26.10.2017, 17:28 +0100 schrieb Emil Velikov:
> 
> >  .../tests/test_glsl_to_tgsi_lifetime.cpp           | 1278
> > +++++++++++++++-----
> 
> JFYI you'd want to explicitly undef NDEBUG in the test.
> git grep -10 "#undef NDEBUG" -  for examples
> 
> Otherwise the asserts will not trigger since they're not around ;-)
> 

Well, these asserts are not testing library code, they just check the
sanity of the test setup, i.e. whether the mock shaders use the right
number of source and destination registers with respect to the opcodes.
With that in mind I don't think that they really need to be around in a
release check build. 

Nevertheless, I will contemplate whether it makes sence to replace them
with the Google test ASSERT_EQ. 

thanks for the pointer anyway, 
Gert