[Mesa-dev] [PATCH v2 0/3] Fix for PerVertexValidation CTS test

Neil Roberts nroberts at igalia.com
Fri Oct 27 19:28:16 UTC 2017


Here is a v2 of Eduardo’s patches to fix the PerVertexValidation CTS
test. They were originally posted here:


The patches needed a non-trivial rebase. The previous discussion was
left with a note saying that there are more cases that should fail but
that weren’t handled by the patches and aren’t checked by the CTS
test. Ie, if the consuming shader doesn’t reference any of the members
of gl_PerVertex then it wouldn’t find the block redefinition. This v2
addresses that by directly fetching the glsl_type for the gl_PerVertex
block from the symbol table rather waiting for an instruction which
references it.

I’ve tested it with Piglit and the public CTS repo and it doesn’t
cause any regressions, and of course it fixes the CTS test.

It might be nice to add a Piglit or CTS test to check this missing

- Neil

Eduardo Lima Mitev (3):
  glsl_parser_extra: Add utility to copy symbols between symbol tables
  glsl: Use the utility function to copy symbols between symbol tables
  glsl/linker: Check that re-declared, inter-shader built-in blocks

 src/compiler/glsl/glsl_parser_extras.cpp    | 68 +++++++++++++++++++++--------
 src/compiler/glsl/glsl_parser_extras.h      |  5 +++
 src/compiler/glsl/link_interface_blocks.cpp | 29 ++++++++++++
 src/compiler/glsl/linker.cpp                | 16 ++-----
 4 files changed, 87 insertions(+), 31 deletions(-)


More information about the mesa-dev mailing list