[Mesa-dev] [PATCH 4/4] i965: Only set key->high_quality_derivatives when it matters.

[Jason Ekstrand]

Have you seen this matter somewhere?  It seems like a reasonable thing to
do none the less.  3 and 4 are

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Sat, Oct 28, 2017 at 10:32 AM, Kenneth Graunke <kenneth at whitecape.org>
wrote:

> This avoids recompiles for shaders that don't use explicit derivatives
> when ctx->Hint.FragmentShaderDerivative == GL_NICEST.
> ---
>  src/mesa/drivers/dri/i965/brw_wm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_wm.c
> b/src/mesa/drivers/dri/i965/brw_wm.c
> index ad1c8aed79e..a1e39b55fcb 100644
> --- a/src/mesa/drivers/dri/i965/brw_wm.c
> +++ b/src/mesa/drivers/dri/i965/brw_wm.c
> @@ -521,6 +521,7 @@ brw_wm_populate_key(struct brw_context *brw, struct
> brw_wm_prog_key *key)
>
>     /* _NEW_HINT */
>     key->high_quality_derivatives =
> +      prog->info.uses_fddx_fddy &&
>        ctx->Hint.FragmentShaderDerivative == GL_NICEST;
>
>     if (devinfo->gen < 6)
> --
> 2.14.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171028/3b387abf/attachment.html>