[Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

Dylan Baker dylan at pnwbakers.com
Mon Oct 30 16:49:45 UTC 2017


for the meson bits:
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

Please do make sure that Daniel or someone else with wayland expertise looks at
this tool, I am not qualified to review that.

Dylan

Quoting Emil Velikov (2017-10-27 16:50:25)
> On 24 October 2017 at 17:14, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > From: Emil Velikov <emil.velikov at collabora.com>
> >
> > The function is effectively a direct function call into
> > libwayland-server.so.
> >
> > Thus GBM no longer depends on the wayland-drm static library, making the
> > build more straight forward. And the resulting binary is a bit smaller.
> >
> > Note: we need to move struct wayland_drm_callbacks further up,
> > otherwise we'll get an error since the type is incomplete.
> >
> > v2: Rebase, beef-up commit message, update meson, move struct
> > wayland_drm_callbacks.
> >
> > Cc: Dylan Baker <dylan at pnwbakers.com>
> > Cc: Daniel Stone <daniels at collabora.com>
> > Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> > Reviewed-by: Daniel Stone <daniels at collabora.com> (v1)
> > ---
> > Dylan can you check the meson bits? Can one say to meson, build object X
> > while only using the depA CFLAGS? It seems to me that it currently links
> > against depA even when you don't want it to.
> >
> Dylan, can you please take a look at the meson bit?
> 
> -Emil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171030/b4cf8cab/attachment.sig>


More information about the mesa-dev mailing list