[Mesa-dev] [PATCH v3 33/34] dri drivers: Always add the sha1 build-id

[Kenneth Graunke]

On Sunday, October 22, 2017 1:01:41 PM PDT Jordan Justen wrote:
> Cc: Dylan Baker <dylanx.c.baker at intel.com>
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/mesa/drivers/dri/Makefile.am | 1 +
>  src/mesa/drivers/dri/meson.build | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/Makefile.am b/src/mesa/drivers/dri/Makefile.am
> index 95c637d0cdd..5cb2127501e 100644
> --- a/src/mesa/drivers/dri/Makefile.am
> +++ b/src/mesa/drivers/dri/Makefile.am
> @@ -57,6 +57,7 @@ mesa_dri_drivers_la_LDFLAGS = \
>  	-module \
>  	-no-undefined \
>  	-avoid-version \
> +	-Wl,--build-id=sha1 \
>  	$(BSYMBOLIC) \
>  	$(GC_SECTIONS) \
>  	$(LD_NO_UNDEFINED)
> diff --git a/src/mesa/drivers/dri/meson.build b/src/mesa/drivers/dri/meson.build
> index 36079324d41..98ed28d04ca 100644
> --- a/src/mesa/drivers/dri/meson.build
> +++ b/src/mesa/drivers/dri/meson.build
> @@ -41,7 +41,7 @@ if dri_drivers != []
>                   libmesa_util, libnir, libmesa_classic],
>      dependencies : [dep_selinux, dep_libdrm, dep_expat, dep_m, dep_thread,
>                      dep_dl],
> -    link_args : [ld_args_bsymbolic, ld_args_gc_sections],
> +    link_args : ['-Wl,--build-id=sha1', ld_args_bsymbolic, ld_args_gc_sections],
>    )
>  
>    pkg.generate(
> 

The autotools bits look fine to me.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171030/e6d7deb1/attachment.sig>