[Mesa-dev] [PATCH 2/2] broadcom/genxml: Fix decoding of groups with small fields.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> Groups containing fields smaller than a byte probably not being decoded
> correctly.  For example:
>
>     <group count="32" start="32" size="4">
>       <field name="Vertex Element Enables" start="0" end="3" type="uint"/>
>     </group>
>
> gen_field_iterator_next would properly walk over each element of the
> array, incrementing group_iter.  However, the code to print the actual
> values only considered iter->field->start/end, which are 0 and 3 in the
> above example.  So it would always fetch bits 3:0 of the current byte,
> printing the same value over and over.

I don't have any groups currently (haven't figured out how to use them
well), but it looks right, so I've reviewed it and it'll be in my next
push.  Thanks for propagating your fix over!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171030/7c783ee4/attachment.sig>