[Mesa-dev] [PATCH 2/2] meson: set visibility flags on gbm

Eric Engestrom eric.engestrom at imgtec.com
Tue Oct 31 10:32:47 UTC 2017


On Monday, 2017-10-30 11:32:34 -0700, Dylan Baker wrote:
> This is done in autotools, and is an oversight in the meson build.
> 
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>  src/gbm/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gbm/meson.build b/src/gbm/meson.build
> index fc1816cc17a..2fad2a2a8e3 100644
> --- a/src/gbm/meson.build
> +++ b/src/gbm/meson.build
> @@ -50,7 +50,7 @@ libgbm = shared_library(
>    include_directories : [
>      include_directories('main'), inc_include, inc_src, inc_loader,
>      include_directories('../egl/wayland/wayland-drm')],
> -  c_args : args_gbm,
> +  c_args : [c_vis_args, args_gbm],

both patches are
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

and this one is also
Tested-by: Eric Engestrom <eric.engestrom at imgtec.com>

but it's not enough to fix `meson test` (which btw has bugs, meaning it
doesn't test anything right now; I have a series in progress for this)

>    link_args : [ld_args_gc_sections],
>    link_with : [links_gbm, libloader, libmesa_util, libxmlconfig],
>    dependencies : [deps_gbm, dep_dl],
> -- 
> 2.14.3
> 


More information about the mesa-dev mailing list